Add FFXIV Chinese version (6.5) support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge this and point it back to the Dalamud Machina branch, since #77 is probably a bit more involved to get going for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 6.5, The Chinese version of FFXIV has finally Dalamud API 9 landed. We can support both Chinese version and global version in one assembly.
Add the logic to check Chinese version of FFXIV and download Chinese version of parsing plugin. I'm using
dalamudClientLanguage.ToString() == "ChineseSimplified"since the global version of Dalamud doesn't have theChineseSimplifiedenum value.Also added Chinese version's opcodes (6.5 currently) for machina, which is not available in the
ravahn/machinarepo. In the long term I'd like to move to using the opcodes from the bundled machina library rather than an own copy.